Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Sep 26, 2024

Check libs workflow also relied on the tox wrappers

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (9c6e6a7) to head (ef36c32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files          12       12           
  Lines        3048     3048           
  Branches      539      539           
=======================================
  Hits         2161     2161           
  Misses        771      771           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp changed the title [MISC] Fix lib check [MISC] Disable tox requirements generation for check libraries flow Sep 26, 2024
@dragomirp dragomirp marked this pull request as ready for review September 26, 2024 11:24
@taurus-forever
Copy link
Contributor

@carlcsaposs-canonical
Copy link
Contributor

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might need something like https://github.com/canonical/mysql-router-k8s-operator/blob/da06da4c976352688e1e657b9ff9e2837dee0d15/.github/workflows/ci.yaml#L55-L56 as long as we're using charmcraft 2.x

if you're using charmcraft 3 for the check-libs action, disregard

@dragomirp dragomirp merged commit bfc9f05 into main Sep 26, 2024
94 checks passed
@dragomirp dragomirp deleted the lib-check branch September 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants