Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Oct 2, 2024

If the Posgresql and Pgbouncer charms are collocated on the same host, both will try to create a psql alias. The charm should ignore errors during alias creation, since the alias is not a critical component and collocation of both charms is a valid use case

Related to #636

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (a8024fd) to head (f01b799).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/charm.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   70.89%   70.81%   -0.09%     
==========================================
  Files          12       12              
  Lines        3048     3053       +5     
  Branches      539      539              
==========================================
+ Hits         2161     2162       +1     
- Misses        771      775       +4     
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp marked this pull request as ready for review October 2, 2024 14:15
@dragomirp dragomirp requested review from a team, taurus-forever, marceloneppel and lucasgameiroborges and removed request for a team October 2, 2024 14:15
@dragomirp dragomirp merged commit ef94d6c into main Oct 3, 2024
94 checks passed
@dragomirp dragomirp deleted the dpe-5594-ignore-existing-alias branch October 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants