Skip to content

[DPE-6056] Add preload libs to regular startup parameters #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2025
Merged

[DPE-6056] Add preload libs to regular startup parameters #741

merged 3 commits into from
Jan 27, 2025

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Jan 24, 2025 •
edited
Loading

Should fix missing preload libs during upgrade

Port of canonical/postgresql-k8s-operator#774

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.38%. Comparing base (3a22b42) to head (bd5503c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          15       15           
  Lines        3253     3253           
  Branches      480      480           
=======================================
  Hits         2322     2322           
  Misses        812      812           
  Partials      119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp changed the title [DPE-6056] Add preload libs to regular startup params [DPE-6056] Add preload libs to regular startup parameters Jan 24, 2025
@dragomirp dragomirp marked this pull request as ready for review January 24, 2025 12:02
@dragomirp dragomirp requested review from a team, taurus-forever, marceloneppel and lucasgameiroborges and removed request for a team January 24, 2025 12:02
dragomirp
dragomirp commented Jan 24, 2025
View reviewed changes
tests/integration/ha_tests/test_upgrade_from_stable.py
logger = logging.getLogger(__name__)

TIMEOUT = 600
TIMEOUT = 900
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timing out on CI e.g. https://github.com/canonical/postgresql-operator/actions/runs/12948714150/job/36124952260

taurus-forever
taurus-forever approved these changes Jan 27, 2025
View reviewed changes
templates/patroni.yml.j2
bin_dir: /snap/charmed-postgresql/current/usr/lib/postgresql/{{ version }}/bin
data_dir: {{ data_path }}
parameters:
shared_preload_libraries: 'timescaledb,pgaudit'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does CI tests passed with this line? LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue affects only the followers, which is why the tests pass. I think going forward we should try to move most (all?) bootstrap params into the regular params, so we have a single source of truth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. the patch should work AS IS, AFAIK. Do you want to merge it or proceed with refactoring now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. the patch should work AS IS, AFAIK. Do you want to merge it or proceed with refactoring now?

Let's merge this as is and leave the refactoring for better days.

@dragomirp dragomirp merged commit ac5df63 into main Jan 27, 2025
91 checks passed
@dragomirp dragomirp deleted the dpe-6056-pgaudit branch January 27, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taurus-forever taurus-forever taurus-forever approved these changes

@marceloneppel marceloneppel marceloneppel approved these changes

@lucasgameiroborges lucasgameiroborges Awaiting requested review from lucasgameiroborges lucasgameiroborges was automatically assigned from canonical/data-postgresql

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragomirp @taurus-forever @marceloneppel