[DPE-6555] Add read only URIs #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 71.97% 71.94% -0.04%
==========================================
Files 15 15
Lines 3479 3482 +3
Branches 532 533 +1
==========================================
+ Hits 2504 2505 +1
- Misses 845 846 +1
- Partials 130 131 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-6555-read-only-uri
branch
from
70d11a7 to
5a84388
Compare
dragomirp
commented
Mar 14, 2025
Comment on lines
+965
to
+968
| # When removing all units sometimes the last unit remain in the list | ||
| current_units = {unit.name for unit in ops_test.model.applications[app].units} | ||
| original_units.intersection_update(current_units) | ||
| assert original_units.issubset(current_units), "New unit not added to model" |
There was a problem hiding this comment.
Annoying failure in the restore cluster test. Last unit remains in the list of units when scaling down to zero.
dragomirp
requested review from
a team,
taurus-forever and
marceloneppel
and removed request for
a team
marceloneppel
approved these changes
Mar 17, 2025
taurus-forever
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dpl changes PR: canonical/data-platform-libs#206