[MISC] Fix cluster initialize on primary #826
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug, where upon cluster initialization, the primary instance was waiting on Patroni
member_started
, instead on the primary endpoint being available.This approach falls short when performing further operations on the
_start_primary
method, as the default database cannot be connected to when trying to list users / groups (see failing CI job). The problem has been surfaced after correctly closing the connection on the PostgreSQLlist_users
charm lib method.