-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-6189] Manage passwords with user secrets #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (15.87%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #833 +/- ##
===========================================
- Coverage 72.14% 71.10% -1.04%
===========================================
Files 14 14
Lines 3701 3724 +23
Branches 548 553 +5
===========================================
- Hits 2670 2648 -22
- Misses 854 899 +45
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like the downgrade of LXD to LTS version didn't get applied in the merge of main and it is likely causing the instability of the arm self healing test. Started a new merge in #843 including a manual addition of that change. I think it's OK the merge the current PR as is or alternatively I can sync it up after #843 gets merged. @reneradoi, @marceloneppel what do you think? |
Thank you for investigating the failure @dragomirp , I'm fine with merging it as it is (after Marcelo confirmed the testing) if there's no concerns from your side. |
backported from
postgresql-k8s-operatorThis PR introduces juju user secrets for managing passwords. It contains the following changes:
Functionality:
get-passwordandset-passwordactionssystem-usersto configure a secret that includes the system users' password(s)Implementation:
secret_changedevent tocharm.pyget_secret_from_id()tocharm.pyconfig_changedleader_electedget_passwordhandlerset_passwordhandler with_update_admin_passwords()method_update_admin_passwords()is responsible for the actual business logic:postgresql.update_user_password()methodTesting: