feat: [DPE-6904] Spaces support #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #857 +/- ##
===========================================
- Coverage 70.83% 70.67% -0.16%
===========================================
Files 15 15
Lines 3888 3956 +68
Branches 580 590 +10
===========================================
+ Hits 2754 2796 +42
- Misses 949 970 +21
- Partials 185 190 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulomach
commented
Apr 30, 2025
| [tool.ruff.lint] | ||
| explicit-preview-rules = true | ||
| select = ["A", "E", "W", "F", "C", "N", "D", "I001", "B", "CPY", "RUF", "S", "SIM", "UP", "TC"] | ||
| select = [ |
Contributor
Author
There was a problem hiding this comment.
my editor just formatted the toml.. changes here are just add jubilant
Contributor
Author
|
Fixed on jubilant-1.0.1 |
imanenami
reviewed
May 1, 2025
dragomirp
approved these changes
May 2, 2025
marceloneppel
approved these changes
May 2, 2025
Member
marceloneppel
left a comment
marceloneppel
left a comment
There was a problem hiding this comment.
LGTM! I tested async replication, and it's working fine with spaces. Thank you so much, Paulo!
* sometimes, a stopped member can be down and still be shown as streaming, but with out-of-sync
…to feature/spaces_pg16
…to feature/spaces_pg16
…to feature/spaces_pg16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently juju network spaces is not supported.
Solution
Testing:
There's a charmhub branch for testing
16/edge/spaces(rev614)If testing on LXD, refer to the conftest.py on how to setup LXD networks to enable manual testing, as there some catches on default configuration.
Checklist