[DPE-6965] Wait for all storages to detatch in smoke test #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…ools Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…ools Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
added
the
not bug or enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #869 +/- ##
========================================
Coverage 70.83% 70.83%
========================================
Files 15 15
Lines 3888 3888
Branches 580 580
========================================
Hits 2754 2754
Misses 949 949
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
changed the title
dragomirp
commented
May 5, 2025
| timeout-minutes: 1 | ||
| if: ${{ !contains(matrix.job.spread_job, 'juju29') && (success() || (failure() && steps.spread.outcome == 'failure')) }} | ||
| run: sudo juju status --color --relations | tee ~/logs/juju-status.txt | ||
| run: sudo juju status --color --relations --storage | tee ~/logs/juju-status.txt |
Contributor
Author
There was a problem hiding this comment.
For easier debug in the future.
dragomirp
commented
May 5, 2025
Comment on lines
+45
to
+48
| "archive": {"pool": "lxd-btrfs", "size": 2048}, | ||
| "data": {"pool": "lxd-btrfs", "size": 2048}, | ||
| "logs": {"pool": "lxd-btrfs", "size": 2048}, | ||
| "temp": {"pool": "lxd-btrfs", "size": 2048}, |
Contributor
Author
There was a problem hiding this comment.
Reduce volume sizes, we may run into disk space issues in the future.
dragomirp
commented
May 5, 2025
Comment on lines
+109
to
+110
| assert len(garbage_storages) == 4 | ||
| logger.info(f"Collected storages: {garbage_storages}") |
Contributor
Author
There was a problem hiding this comment.
Before we waited for a single storage to detach, but now we need all four of them to redeploy.
dragomirp
commented
May 5, 2025
Comment on lines
-165
to
-173
| await ops_test.model.set_config({"update-status-hook-interval": "10s"}) | ||
|
|
||
| logger.info("waiting for duplicate application to be blocked") | ||
| try: | ||
| async with ops_test.fast_forward("60s"): | ||
| logger.info("waiting for duplicate application to be waiting") | ||
| await ops_test.model.wait_for_idle( | ||
| apps=[DUP_APPLICATION_NAME], timeout=1000, status="blocked" | ||
| apps=[DUP_APPLICATION_NAME], timeout=1000, status="waiting", idle_period=30 | ||
| ) | ||
| except asyncio.TimeoutError: | ||
| logger.info("Application is not in blocked state. Checking logs...") |
Contributor
Author
There was a problem hiding this comment.
We don't actually block here. The test just spend a bunch of time in waiting for idle.
Contributor
There was a problem hiding this comment.
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
marceloneppel
approved these changes
May 5, 2025
Comment on lines
+109
to
+110
| assert len(garbage_storages) == 4 | ||
| logger.info(f"Collected storages: {garbage_storages}") |
dragomirp
changed the title
taurus-forever
approved these changes
May 6, 2025
taurus-forever
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilise smoke test for storage.
Checklist