Skip to content

Conversation

taurus-forever
Copy link
Contributor

@taurus-forever taurus-forever commented Jun 10, 2025

Issue

The newly merged PR (with snap bump) has passed PR testing[1] but failing on release[2].
The reason here is a test imperfection (we've missed the on-Git case):

  • on-PR: we are testing incompatible case (due to +dirty charm.py version)
  • on-Git: we are testing compatible case, paused after the first unit upgrade

[1] #943
[2] https://github.com/canonical/postgresql-operator/actions/runs/15539934165/job/43748494710

Solution

Improve the test to support both cases: on-PR and on-Git for already merged PRs.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@taurus-forever taurus-forever changed the base branch from main to 16/edge June 10, 2025 10:19
@taurus-forever taurus-forever force-pushed the alutay/upgrade_test_fix branch from 91dc9c8 to 7fb9350 Compare June 10, 2025 10:20
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (4ba3220) to head (7fb9350).
Report is 1 commits behind head on 16/edge.

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge     #955   +/-   ##
========================================
  Coverage    70.23%   70.23%           
========================================
  Files           16       16           
  Lines         3723     3723           
  Branches       541      541           
========================================
  Hits          2615     2615           
  Misses         974      974           
  Partials       134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taurus-forever taurus-forever changed the title Alutay/upgrade test fix [DPE-7502] Improve upgrade tests to support both (in)compatible scenarios Jun 10, 2025
@taurus-forever taurus-forever marked this pull request as ready for review June 10, 2025 11:53
@taurus-forever
Copy link
Contributor Author

taurus-forever commented Jun 10, 2025

Tested as Merged PR in private fork: here and here.

@dragomirp dragomirp added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Jun 10, 2025
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much, @taurus-forever!

@taurus-forever taurus-forever merged commit da66db9 into canonical:16/edge Jun 10, 2025
137 of 151 checks passed
@taurus-forever taurus-forever deleted the alutay/upgrade_test_fix branch June 10, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants