feat(lxd): support launching minimal images on lxd_vm and container (SC-1750) #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
lxd-minimal-images-sc-1750
branch
from
b1951ab
to
765909a
Compare
2 tasks
blackboxsw
changed the title
a-dubs
requested changes
Sep 10, 2024
| "grep build_name /etc/cloud/build.info" | ||
| ).stdout | ||
| ) | ||
| instance.delete() |
There was a problem hiding this comment.
should this test be added to an lxd integration test instead? given that this will only run on lxd and the public api is unaffected by this change?
There was a problem hiding this comment.
Good suggestion, I pulled it into a separate test and also parametrized that test to cover GCE and Ec2 which also support ImageType.MINIMAL image_type overrides in released_image/daily_image
blackboxsw
force-pushed
the
lxd-minimal-images-sc-1750
branch
from
765909a
to
0fff618
Compare
blackboxsw
force-pushed
the
lxd-minimal-images-sc-1750
branch
3 times, most recently
from
9ed7091
to
fb88f9d
Compare
a-dubs
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Changes look great! Thanks @blackboxsw. Left one inline question but it's minor so I'm not going to block on it.
Add optional image_type param to LXD*.released_image and daily_image methods to provide daily and released Ubuntu minimal images. To support this feature, lxd._images.find_last_fingerprint also accepts an image_type param to distinguish between ubuntu-minimal and generic ubuntu image remotes. Support for jenkins integration test runners of Ubuntu daily minimal images. Component of improved integration test coverage for SC-1750.
blackboxsw
force-pushed
the
lxd-minimal-images-sc-1750
branch
from
fb88f9d
to
d059d37
Compare
a-dubs
added a commit
to a-dubs/pycloudlib
that referenced
this pull request
Sep 13, 2024
PR canonical#410 introduced minimal images and added integration test coverage for EC2 and GCE but the helper functions used to find images on those clouds were not updated. This fixes this issue and should include all the remaining functionality needed for minimal images to work on those clouds.
a-dubs
added a commit
to a-dubs/pycloudlib
that referenced
this pull request
Sep 13, 2024
PR canonical#410 introduced minimal images and added integration test coverage for EC2 and GCE but the helper functions used to find images on those clouds were not updated. This fixes this issue and should include all the remaining functionality needed for minimal images to work on those clouds.
a-dubs
added a commit
to a-dubs/pycloudlib
that referenced
this pull request
Sep 13, 2024
PR canonical#410 introduced minimal images and added integration test coverage for EC2 and GCE but the helper functions used to find images on those clouds were not updated. This fixes this issue and should include all the remaining functionality needed for minimal images to work on those clouds.
blackboxsw
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR #410 introduced minimal images and added integration test coverage for EC2 and GCE but the helper functions used to find images on those clouds were not updated. This fixes this issue and should include all the remaining functionality needed for minimal images to work on those clouds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional image_type param to LXD*.released_image and daily_image methods to provide daily and released Ubuntu minimal images.
To support this feature, lxd._images.find_last_fingerprint also accepts an image_type param to distinguish between ubuntu-minimal and generic ubuntu image remotes.
Support for jenkins integration test runners of Ubuntu daily minimal images. Component of improved integration test coverage for SC-1750.
test procedure