-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cve-check): check for cves #10
base: main
Are you sure you want to change the base?
Conversation
7ab7769
to
5b9908c
Compare
The multiple runners thing was integrated, although there is a limitation in GH reusable workflows and matrix output: https://github.com/orgs/community/discussions/17245 Should we remove the runner matrix from the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add an example of this to the '-test' repo?
Nevermind, just seen the follow up pr.
description: The channel of the snap to scan. | ||
required: false | ||
type: string | ||
runs-on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to specify a runner? Can't we run an amd64 review-tools
snaps on an arm64 snap? Can we download an arm64 snap file on an amd64 machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find a way to specify the arch from the snap download
command. This means that snap download
download the snap from the architecture of the host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage:
snap download [download-OPTIONS] <snap>
The download command downloads the given snap and its supporting assertions
to the current directory with .snap and .assert file extensions, respectively.
[download command options]
--channel= Use this channel instead of stable
--edge Install from the edge channel
--beta Install from the beta channel
--candidate Install from the candidate channel
--stable Install from the stable channel
--revision= Download the given revision of a snap
--basename= Use this basename for the snap and assertion files (defaults to <snap>_<revision>)
--target-directory= Download to this directory (defaults to the current directory)
--cohort= Download from the given cohort
The |
Tested here: canonical/robotics-action-workflows-tests#4