Make chisel a build snap #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
force-pushed
the
ROCKS-936/make-rockcraft-pull-chisel-at-pack-time
branch
from
b473145
to
6829757
Compare
|
Here are successful examples of running
|
|
@cjdcordeiro @tigarmo This is ready for review. See examples of running it above. Before merging this, PR #637 needs to be merged first, and function |
linostar
force-pushed
the
ROCKS-936/make-rockcraft-pull-chisel-at-pack-time
branch
from
cfddc15
to
4248878
Compare
cjdcordeiro
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Nice. Short and sweet. I'm adding a label to be explicit that canonical/craft-parts#637 should be merged first
Comment on lines
+48
to
+52
| # this will be removed once part_has_slices is added to craft-parts | ||
| def part_has_slices(data: dict[str, Any]) -> bool: | ||
| stage_packages = data.get("stage-packages", []) | ||
| return any(name for name in stage_packages if "_" in name) | ||
|
|
There was a problem hiding this comment.
still within this PR right? Since we're waiting for canonical/craft-parts#637
|
|
||
| services = cast(RockcraftServiceFactory, self._services) | ||
| image_service = services.image | ||
| image_info = image_service.obtain_image() | ||
| needs_chisel = any(part for part in parts if part_has_slices(parts[part])) |
There was a problem hiding this comment.
I guess this will also slightly change after canonical/craft-parts#637
There was a problem hiding this comment.
yes, it will become craft_parts.part_has_slices instead.
There was a problem hiding this comment.
We can move detection and chisel installing to craft-parts, it already does that with other tools such as git.
tigarmo
reviewed
Jan 29, 2024
Open
1 task
|
Hey everyone. I wanted to check in on this PR; I'm worried its getting a little stale. 🦇 |
We're still waiting for chisel to release its first stable release, so I guess let's keep it open until then. |
lengau
reviewed
Aug 28, 2024
github-actions
bot
added
the
documentation
|
Chisel v1.0.0 has been released in candidate channel. It will be released in stable channel in about 2 weeks. |
|
Chisel is now owned by canonical (@rebornplusplus ) so this PR can be resumed |
|
We also need this PR (or a new release) for 1.0.0 to become available in rockcraft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chisel isn't wanted to be embedded in rockcraft snap, so it is set to be a build-snap instead.