Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language changes, pop-up warning, clarify instructions #709

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

erinecon
Copy link
Contributor

@erinecon erinecon commented Sep 18, 2024

  • Update the language to be more aligned with a tutorial, i.e., a learning experience we're going on together

  • Added a note about a pop-up window that may appear when the user installs python-venv

  • Clarified instructions in the "Update Django application" section to replace the contents of the time_app/views.py and django_hello_world/urls.py files. If the user inserts the contents without replacing the previous text, this leads to an Internal Service Error when the user sends a request to the /time/ endpoint.

  • Have you signed the CLA?


- Update the language to be more aligned with a tutorial, i.e., a learning experience we're going on together
- Added a note about a pop-up window that may appear when the user installs python-venv
- Clarified instructions in the "Update Django application" section to replace the contents of the time_app/views.py and django_hello_world/urls.py files. If the user inserts the contents without replacing the previous text, this leads to an Internal Service Error when the user sends a request to the /time/ endpoint.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 18, 2024
docs/tutorial/django.rst Outdated Show resolved Hide resolved
@jdkandersson
Copy link
Contributor

Perhaps ping @tigarmo to get this pr reviewed 🙂

docs/tutorial/django.rst Outdated Show resolved Hide resolved
docs/tutorial/django.rst Outdated Show resolved Hide resolved
docs/tutorial/django.rst Outdated Show resolved Hide resolved
erinecon and others added 2 commits September 23, 2024 08:53
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tigarmo tigarmo added the squash label Sep 25, 2024
@tigarmo tigarmo merged commit 2c375fe into canonical:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants