Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update deps with freeze-requirements #731

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Oct 11, 2024

This commit also updates freeze-requirements to use 'pip-compile' instead of 'pip freeze'. The reason for this is that 'pip freeze' does not preserve the 'extras' of each dependency listed in the project's dependencies, which in this particular case is relevant for the 'canonical-sphinx[full]' change.

pip-compile also has the side-effect of showing where each transient dependency came from, which is very nice!

  • Have you signed the CLA?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 11, 2024
@tigarmo tigarmo marked this pull request as ready for review October 11, 2024 22:27
@tigarmo tigarmo requested review from lengau and a team October 11, 2024 22:29
This commit also updates freeze-requirements to use 'pip-compile' instead of
'pip freeze'. The reason for this is that 'pip freeze' does not preserve the
'extras' of each dependency listed in the project's dependencies, which in
this particular case is relevant for the 'canonical-sphinx[full]' change.

pip-compile also has the side-effect of showing where each transient dependency
came from, which is very nice!
This feature isn't present on canonical-sphinx 0.1.0, and raises git-related
errors on our readthedocs builds.
@lengau lengau requested a review from a team October 12, 2024 11:32
@sergiusens sergiusens merged commit 9261dc7 into main Oct 14, 2024
15 checks passed
@sergiusens sergiusens deleted the work/update-deps branch October 14, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants