-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): add automated release workflow #2
chore(release): add automated release workflow #2
Conversation
Adds a workflow file which can be run to create a semantic tag and immediately afterwards, create a release on GitHub. Any collaborator with write access should be able to trigger the workflow. This commit also adds another workflow file, which leaves a comment after a PR has been merged. The comment reminds to trigger the aforementioned release workflow.
Can the |
Yup, for sure, it can be. But I think we don't want to release versions after every PR merge. Some PRs may be insignificant, or sometimes irrelevant to contribute to a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! Left a few comments. Do you have an example of this workflow's results?
You can check out the releases and workflow runs at https://github.com/rebornplusplus/rocks-toolbox. It may be a bit messy there, lots of experiment runs. Additionally, I will outline the behaviour of the workflow for clarity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the example and diagram. It's LGTM...just need to polish the last two comments and that should be it
Great, thanks. merging |
Adds a workflow file which can be run to create a semantic tag and immediately afterwards, create a GitHub release. Any collaborator with write access should be able to trigger the workflow.
This PR also adds another workflow file, which leaves a comment after a PR has been merged. The comment reminds to trigger the aforementioned release workflow.
The tags will be automatically created using semantic versioning. However, the very first tag should be specified manually in the workflow input. The release types (patch, minor or major) are determined by the commit messages. Please see https://github.com/marketplace/actions/github-tag#bumping to learn more.