Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register start handler also when config is invalid #37

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

arturo-seijas
Copy link
Collaborator

The start handler is currently not registered when a charm is deployed without a proper configuration and this is fixed later

@arturo-seijas arturo-seijas requested a review from a team as a code owner August 16, 2023 12:39
amandahla
amandahla previously approved these changes Aug 16, 2023
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Test coverage for 965ea07

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
lib/charms/saml_integrator/v0/saml.py      89      0     16      0   100%
src/charm.py                               43      1      4      0    98%   60
src/charm_state.py                         35      0      6      0   100%
src/saml.py                                60      0     10      0   100%
-----------------------------------------------------------------------------------
TOTAL                                     227      1     36      0    99%

Static code analysis report

Run started:2023-08-16 14:11:22.513295

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 942
  Total lines skipped (#nosec): 5
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 4ff41a1 into main Aug 16, 2023
@arturo-seijas arturo-seijas deleted the fix-package-installation branch August 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants