Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread: fix python-hello #3670

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Mar 25, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

setuptools-61.1.0 broke two spread tests:

  • tests/spread/plugins/v2/build-and-run-hello:python_multiple_parts
  • tests/spread/plugins/v2/build-and-run-hello:python_multiple_parts_staged

The following error is produced:

Successfully installed pip-22.0.4 setuptools-61.0.0 wheel-0.37.1
+ '[' -f setup.py ']'
+ pip install -U .
Processing /root/parts/hello/build
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      error: Multiple top-level packages discovered in a flat-layout: ['snap', 'empty'].

      To avoid accidental inclusion of unwanted files or directories,
      setuptools will not proceed with this build.

      If you are trying to create a single distribution with multiple packages
      on purpose, you should not rely on automatic discovery.
      Instead, consider the following options:

      1. set up custom discovery (`find` directive with `include` or `exclude`)
      2. use a `src-layout`
      3. explicitly set `py_modules` or `packages` with a list of names

      To find more information, look for "package discovery" on setuptools docs.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Failed to build 'hello'.

Recommended resolution:
Check the build logs and ensure the part's configuration and sources are correct.
Run the same command again with --debug to shell into the environment if you wish to introspect this failure.

source: pypa/setuptools#2894

@mr-cal mr-cal force-pushed the spread-fix-python-hello branch from 94c2aeb to d59a4c4 Compare March 25, 2022 19:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #3670 (d59a4c4) into main (ce1c558) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3670   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         278      278           
  Lines       19396    19396           
=======================================
  Hits        17699    17699           
  Misses       1697     1697           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sergiusens sergiusens merged commit 4fa3a97 into canonical:main Mar 25, 2022
@mr-cal mr-cal deleted the spread-fix-python-hello branch March 25, 2022 21:54
@mr-cal mr-cal mentioned this pull request Mar 25, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants