Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: support top-level provenance keyword for on-prem support #3963

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 26, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

The provenance key in snapcraft.yaml can now be moved from underneath passthrough to a top-level key.

(CRAFT-1423)

The `provenance` key in snapcraft.yaml can now be moved from
underneath `passthrough` to a top-level key.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #3963 (dc703fb) into main (47317e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3963   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          56       56           
  Lines        4083     4084    +1     
=======================================
+ Hits         3718     3719    +1     
  Misses        365      365           
Impacted Files Coverage Δ
snapcraft/meta/snap_yaml.py 96.39% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 27, 2022

Spread failure unrelated (#3962)

Copy link
Contributor

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! +1, but check comment, thanks!!

snapcraft/projects.py Outdated Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 27, 2022

Set to auto-merging, but I can't merge to main with 1 unrelated spread failure (resolved by #3962)

@mr-cal mr-cal enabled auto-merge (squash) October 27, 2022 22:07
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (but a test failed)

@mr-cal mr-cal merged commit 5799b03 into canonical:main Nov 3, 2022
@mr-cal mr-cal deleted the on-prem-provenance branch November 4, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants