linters: don't list dynamic linker as missing library #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating library linker warnings, don't consider the dynamic linker when checking for missing libraries. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
mr-cal
approved these changes
Nov 23, 2022
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Codecov Report
@@ Coverage Diff @@
## hotfix/7.2 #3989 +/- ##
==============================================
- Coverage 91.04% 90.99% -0.06%
==============================================
Files 56 56
Lines 4078 4088 +10
==============================================
+ Hits 3713 3720 +7
- Misses 365 368 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating library linker warnings, don't consider the dynamic linker when checking for missing libraries.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com
make lint?pytest tests/unit?