requirements: pin setuptools<66 #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
approved these changes
Feb 7, 2023
cmatsuoka
approved these changes
Feb 7, 2023
lengau
requested changes
Feb 7, 2023
Setuptools>=66 enforces versioning requirements from PEP440, which causes some of the unit tests to fail. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
setuptools-pin
branch
from
fe40fc4
to
204776a
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4031 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 78 78
Lines 5192 5192
=======================================
Hits 4761 4761
Misses 431 431
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lengau
approved these changes
Feb 7, 2023
OzVazquez
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?setuptools>=66enforces versioning requirements from PEP 440, which causes some of the unit tests to fail.Added comments and a TODO so it can be resolved in the future.