-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions: fix neon-extension issues for core22 #4060
Conversation
ac87239
to
f3508b5
Compare
f3508b5
to
0485f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Not sure why the tests have been queued for 30 minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mr-cal to answer your question: We have a bunch of old tests still running. I'm guessing it's because of my |
The lint issues are fixed in #4059 |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## hotfix/7.3 #4060 +/- ##
=============================================
Coverage ? 91.80%
=============================================
Files ? 79
Lines ? 5299
Branches ? 0
=============================================
Hits ? 4865
Misses ? 434
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- moved back to the full blown command-chain for KDE Neon - removed dependency on bindtextdomain - updated the pattern match for kde sdk snaps - tests updated to conside core22 - fixed the added part names Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
0485f16
to
33e679e
Compare
moved back to the full blown command-chain for KDE Neon
removed dependency on bindtextdomain
updated the pattern match for kde sdk snaps
tests updated to consider core22
fixed the added part names
Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run
make lint
?Have you successfully run
pytest tests/unit
?