Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: fix neon-extension issues for core22 #4060

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Mar 8, 2023

  • moved back to the full blown command-chain for KDE Neon

  • removed dependency on bindtextdomain

  • updated the pattern match for kde sdk snaps

  • tests updated to consider core22

  • fixed the added part names

  • Have you followed the guidelines for contributing?

  • Have you signed the CLA?

  • Have you successfully run make lint?

  • Have you successfully run pytest tests/unit?


@sergiusens sergiusens changed the base branch from main to hotfix/7.3 March 8, 2023 22:18
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Not sure why the tests have been queued for 30 minutes

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lengau
Copy link
Contributor

lengau commented Mar 8, 2023

@mr-cal to answer your question: We have a bunch of old tests still running. I'm guessing it's because of my if: always() on the tox workflow for uploading test results. I'll do a quick PR to fix that across all of our apps

@lengau
Copy link
Contributor

lengau commented Mar 9, 2023

The lint issues are fixed in #4059

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/7.3@1914eb9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0485f16 differs from pull request most recent head 33e679e. Consider uploading reports for the commit 33e679e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             hotfix/7.3    #4060   +/-   ##
=============================================
  Coverage              ?   91.80%           
=============================================
  Files                 ?       79           
  Lines                 ?     5299           
  Branches              ?        0           
=============================================
  Hits                  ?     4865           
  Misses                ?      434           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- moved back to the full blown command-chain for KDE Neon
- removed dependency on bindtextdomain
- updated the pattern match for kde sdk snaps
- tests updated to conside core22
- fixed the added part names

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens enabled auto-merge (squash) March 9, 2023 14:44
@sergiusens sergiusens merged commit bef32e2 into hotfix/7.3 Mar 9, 2023
@sergiusens sergiusens deleted the hotfix/7.3-kde-neon branch March 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants