Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure workflows are cancellable #4061

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Mar 8, 2023

Committed via https://github.com/asottile/all-repos

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #4061 (877f3af) into main (255255f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4061   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         641      641           
  Lines       51772    51772           
=======================================
  Hits        48972    48972           
  Misses       2800     2800           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that all-repos I see?!

Looks good, except for the commit failing the CLA check

@lengau
Copy link
Contributor Author

lengau commented Mar 9, 2023

Yeah, I forgot to add my new all-repos directory to my work email git config. I decided signing the CLA with my personal account would be the easier fix so the CLA check on the merge should pass now.

@mr-cal mr-cal enabled auto-merge (squash) March 9, 2023 15:46
@mr-cal mr-cal merged commit 2d6a1cd into canonical:main Mar 9, 2023
@lengau lengau deleted the all-repos_autofix_all-repos-sed branch March 9, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants