Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: migrate to core22 #4186

Merged
merged 5 commits into from
Jul 3, 2023
Merged

snap: migrate to core22 #4186

merged 5 commits into from
Jul 3, 2023

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

snap/snapcraft.yaml Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #4186 (aeac323) into main (89c1d50) will increase coverage by 4.91%.
The diff coverage is n/a.

❗ Current head aeac323 differs from pull request most recent head fd09fb5. Consider uploading reports for the commit fd09fb5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #4186      +/-   ##
==========================================
+ Coverage   88.98%   93.90%   +4.91%     
==========================================
  Files         296      569     +273     
  Lines       20192    43746   +23554     
==========================================
+ Hits        17968    41078   +23110     
- Misses       2224     2668     +444     
Impacted Files Coverage Δ
setup.py 100.00% <ø> (ø)

... and 300 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens force-pushed the core22 branch 7 times, most recently from 7a5734c to 0c9249c Compare June 2, 2023 19:51
@sergiusens
Copy link
Collaborator Author

rosbash is an intermittent error, I talked to @Guillaumebeuzeboc about i

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants