Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: remove extra kde-neon build envvars #4242

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Cherry-pick #4193 into hotfix/7.5.

ScarlettGatelyMoore and others added 2 commits June 29, 2023 11:50
remove extra build environment variables that are causing build failures.
@sergiusens
Copy link
Collaborator

@ScarlettGatelyMoore are you sure this change is safe?

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #4242 (eea33f2) into hotfix/7.5 (b6bd029) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4242   +/-   ##
===========================================
  Coverage       94.84%   94.85%           
===========================================
  Files             649      649           
  Lines           54346    54379   +33     
===========================================
+ Hits            51545    51580   +35     
+ Misses           2801     2799    -2     
Impacted Files Coverage Δ
snapcraft/extensions/kde_neon.py 100.00% <ø> (ø)
tests/unit/extensions/test_kde_neon.py 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ScarlettGatelyMoore
Copy link
Contributor

@ScarlettGatelyMoore are you sure this change is safe?

Yes. After removing these two, all my random build failures started building, also other reports on the forums reported this fix fixed their issues. Builds that worked before still work.

@sergiusens
Copy link
Collaborator

thanks for getting back to me @ScarlettGatelyMoore
We shall move forward with it, if you can, please keep an eye on any errors people report on the forum about this extension

@sergiusens sergiusens merged commit cfacbc5 into hotfix/7.5 Jul 12, 2023
11 of 12 checks passed
@sergiusens sergiusens deleted the kde-env-vars branch July 12, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants