Add QT extension #4294

jardon · 2023-07-26T14:43:20Z

Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run make lint?
Have you successfully run pytest tests/unit?

This PR adds support for two QT extensions (6.5 and 5.15)

Add extension handling
Update unit tests
Fixes hardcoded gnome extension script
Update Extension class to pass in extension name

codecov-commenter · 2023-09-26T13:46:07Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d75fdaf) 89.19% compared to head (4d14e4a) 88.35%.
Report is 5 commits behind head on main.

Files	Patch %	Lines
snapcraft/extensions/qt_framework.py	95.83%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
- Coverage   89.19%   88.35%   -0.85%     
==========================================
  Files         322      328       +6     
  Lines       21826    22035     +209     
==========================================
+ Hits        19468    19469       +1     
- Misses       2358     2566     +208

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mr-cal

Looks good, nice work!

Can you create a spread test for 5.15 and 6.5 under tests/spread/extensions/? You can use the other spread tests in that directory as a reference.

schema/snapcraft.json

snapcraft/extensions/qt_framework.py

tests/unit/extensions/test_qt_framework.py

mr-cal

Update for anyone watching:

This PR is waiting on @jardon getting auto-connect approvals for the two qt-framework snaps used by this extension

jardon · 2023-10-19T13:05:42Z

Store request submitted here

sergiusens · 2023-11-13T12:32:09Z

you store request has updates

jardon · 2024-01-04T15:58:00Z

The CI can be rerun when the snapcraft forum post is resolved.

jardon · 2024-02-12T22:32:19Z

@sergiusens @mr-cal do you know where snapctl is getting the qt-framework slot/plug from? I've renamed it in the snaps themselves after being requested in the forums to change it. I dont see it in any of the desktop launch scripts either.

error: error running snapctl: snap "qt6-6-hello" has no plug or slot named "qt-framework"
ERROR: not connected to the qt-framework content interface.

$ snap connections qt6-6-hello 
Interface                         Plug                                 Slot                                             Notes
content[icon-themes]              qt6-6-hello:icon-themes              gtk-common-themes:icon-themes                    -
content[qt-framework-6-6-core22]  qt6-6-hello:qt-framework-6-6-core22  qt-framework-6-6-core22:qt-framework-6-6-core22  -
content[sound-themes]             qt6-6-hello:sound-themes             gtk-common-themes:sound-themes                   -
desktop                           qt6-6-hello:desktop                  :desktop                                         -
desktop-legacy                    qt6-6-hello:desktop-legacy           :desktop-legacy                                  -
opengl                            qt6-6-hello:opengl                   :opengl                                          -
wayland                           qt6-6-hello:wayland                  :wayland                                         -
x11                               qt6-6-hello:x11                      :x11                                             -
jardon@lagaan:~/Projects/snapcraft$ snap connections qt-framework-6-6-core22 
Interface                         Plug                                 Slot                                             Notes
content[qt-framework-6-6-core22]  qt6-6-hello:qt-framework-6-6-core22  qt-framework-6-6-core22:qt-framework-6-6-core22  -

jardon · 2024-02-14T16:11:44Z

@mr-cal Can I get the CI kicked back off?

jardon · 2024-02-14T16:12:10Z

I updated the content snaps to correct the plug check issue

codecov · 2024-02-14T19:11:27Z

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.38%. Comparing base (d364154) to head (6ce8e13).

❗ Current head 6ce8e13 differs from pull request most recent head e1c49e5. Consider uploading reports for the commit e1c49e5 to get more accurate results

Files	Patch %	Lines
snapcraft/extensions/qt_framework.py	97.18%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4294      +/-   ##
==========================================
+ Coverage   88.35%   88.38%   +0.02%     
==========================================
  Files         328      329       +1     
  Lines       22015    22088      +73     
==========================================
+ Hits        19452    19523      +71     
- Misses       2563     2565       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mr-cal

FYI @cmatsuoka, jardon is no longer at Canonical, so I don't think any progress is being made on this. We need to decide what to do with his qt-framework content snaps and this PR.

jardon · 2024-08-22T23:27:14Z

that is more or less correct. this has been demoted in priority for me, but that doesnt mean that i cant work to get this pushed through.

there are a couple of reasons that i havent worked on this in quite a while. firstly, building and maintaining the sdk and content snaps is unfortunately too big of a burden. i cant build the images in github actions because of resource limitations as well as architecture. yes, theres launchpad, but a new coat of paint doesnt mean its basically abandonware (seriously stand up a gitlab instance and convert all the useful bits of launchpad into a plugin or something). secondly, the current snap architecture increases the amount of work beyond whats reasonable. having to have separate snaps for each combination of QT version and base, dealing with the annoyances of the content interface, as well as dealing with store requests makes this a lot to maintain.

if you can offer good solutions to my issues above, i'd be happy to help.

lengau · 2024-09-09T14:48:31Z

snapcraft/extensions/qt_framework.py

+
+_SDK_SNAP = {"core22": "qt-framework-sdk"}
+
+_CONTENT_SNAP = {


Who owns these snaps?

that would be me.

jardon · 2024-09-09T16:43:31Z

For some more context here, I originally wanted to partner with the KDE snap people for creating snaps that would be the building blocks for both extensions. Unfortunately, it seems they got busy with the KDE Ubuntu spin and never responded which is another reason why this stalled.

keshavbhatt · 2024-10-12T06:32:32Z

Any update on this?

jardon · 2024-10-14T17:02:35Z

@keshavbhatt i have not heard back from canonical

mr-cal · 2024-10-15T14:41:51Z

Hi @keshavbhatt, we haven't decided on how to proceed with the QT extension and content snaps.

jardon force-pushed the qt-framework branch from 365703e to 1810cf6 Compare August 21, 2023 14:58

jardon force-pushed the qt-framework branch 2 times, most recently from 6843f00 to 3b07cab Compare September 6, 2023 16:18

jardon marked this pull request as ready for review September 6, 2023 16:18

jardon marked this pull request as draft September 11, 2023 13:51

jardon force-pushed the qt-framework branch from 3b07cab to a4c401f Compare September 15, 2023 13:43

jardon force-pushed the qt-framework branch 3 times, most recently from f9b8cdb to d52c124 Compare September 26, 2023 12:52

jardon marked this pull request as ready for review September 26, 2023 12:56

jardon force-pushed the qt-framework branch from d52c124 to bac174a Compare September 26, 2023 14:10

mr-cal requested changes Sep 26, 2023

View reviewed changes

schema/snapcraft.json Outdated Show resolved Hide resolved

snapcraft/extensions/qt_framework.py Outdated Show resolved Hide resolved

tests/unit/extensions/test_qt_framework.py Outdated Show resolved Hide resolved

jardon requested a review from mr-cal September 27, 2023 18:52

mr-cal reviewed Oct 6, 2023

View reviewed changes

jardon force-pushed the qt-framework branch from e1764c1 to dade930 Compare January 25, 2024 17:44

jardon force-pushed the qt-framework branch from eda56fc to 51ed210 Compare February 23, 2024 17:24

jardon force-pushed the qt-framework branch from 6ce8e13 to e1c49e5 Compare March 7, 2024 17:01

lengau requested review from mr-cal and lengau July 16, 2024 19:20

lengau mentioned this pull request Jul 16, 2024

kde-neon extension support for Qt6 #4148

Closed

mr-cal reviewed Jul 17, 2024

View reviewed changes

lengau reviewed Sep 9, 2024

View reviewed changes

Jarred Wilson and others added 19 commits October 16, 2024 23:48

Add QT extension

6a35653

Fix schema tabs

91fd19e

Fix copyright year in qt_framework.py

31f8179

Parameterize the unit tests

a27b1a7

Add spread tests

325e160

Fix linting

be28619

Fix spread tests

a913525

Fix qt5 refs in qt6 test

d2445a8

Fix spread tests command not found

f248640

Rename plug to match the content snap name

082f5e5

Add qt6-6

37b408e

Fix QT 6.5 reference in 6.6 spread test

44e8868

Add bases to spread tests

ceb06f0

Fix spread snap builds

fa31c1b

Add build and stage packages

079fb6c

Update test_get_part_snippet build and stage packages

10c905c

Remove make builtin logic

de2a11c

Fix None iteration

3467c97

Fix parts snippet tests

86e3c92

jardon force-pushed the qt-framework branch from b137eb4 to 86e3c92 Compare October 16, 2024 23:49

jardon marked this pull request as draft November 12, 2024 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add QT extension #4294

Add QT extension #4294

jardon commented Jul 26, 2023 •

edited

Loading

codecov-commenter commented Sep 26, 2023 •

edited

Loading

mr-cal left a comment

mr-cal left a comment

jardon commented Oct 19, 2023

sergiusens commented Nov 13, 2023

jardon commented Jan 4, 2024

jardon commented Feb 12, 2024

jardon commented Feb 14, 2024

jardon commented Feb 14, 2024

codecov bot commented Feb 14, 2024 •

edited

Loading

mr-cal left a comment

jardon commented Aug 22, 2024 •

edited

Loading

lengau Sep 9, 2024

jardon Sep 9, 2024

jardon commented Sep 9, 2024

keshavbhatt commented Oct 12, 2024

jardon commented Oct 14, 2024

mr-cal commented Oct 15, 2024


		_SDK_SNAP = {"core22": "qt-framework-sdk"}

		_CONTENT_SNAP = {

Add QT extension #4294

Are you sure you want to change the base?

Add QT extension #4294

Conversation

jardon commented Jul 26, 2023 • edited Loading

codecov-commenter commented Sep 26, 2023 • edited Loading

Codecov Report

mr-cal left a comment

Choose a reason for hiding this comment

mr-cal left a comment

Choose a reason for hiding this comment

jardon commented Oct 19, 2023

sergiusens commented Nov 13, 2023

jardon commented Jan 4, 2024

jardon commented Feb 12, 2024

jardon commented Feb 14, 2024

jardon commented Feb 14, 2024

codecov bot commented Feb 14, 2024 • edited Loading

Codecov Report

mr-cal left a comment

Choose a reason for hiding this comment

jardon commented Aug 22, 2024 • edited Loading

lengau Sep 9, 2024

Choose a reason for hiding this comment

jardon Sep 9, 2024

Choose a reason for hiding this comment

jardon commented Sep 9, 2024

keshavbhatt commented Oct 12, 2024

jardon commented Oct 14, 2024

mr-cal commented Oct 15, 2024

jardon commented Jul 26, 2023 •

edited

Loading

codecov-commenter commented Sep 26, 2023 •

edited

Loading

codecov bot commented Feb 14, 2024 •

edited

Loading

jardon commented Aug 22, 2024 •

edited

Loading