Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated parameter build-base #4505

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Stop passing the deprecated parameter build_base to craft-providers to avoid the warning intended for developers:

Deprecated: Parameter 'build_base' is deprecated and should not be used. The build base now comes from the base_configuration's alias.

Note this is already fixed on main.

Source: https://matrix.to/#/!GGqzbFAUQprdPgYYCM:ubuntu.com/$bxytvo9JAtlAkoLNJyXsaQ-4xUM0xRBMLxwP_f1jh34?via=ubuntu.com&via=matrix.org&via=xentonix.net

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from lengau and syu-w January 4, 2024 14:25
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bd0d3a) 94.88% compared to head (23e4031) 94.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           hotfix/7.5    #4505   +/-   ##
===========================================
  Coverage       94.88%   94.88%           
===========================================
  Files             658      658           
  Lines           55192    55192           
===========================================
  Hits            52367    52367           
  Misses           2825     2825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I gather the spread test failures on Ubuntu 18.04 are related to a new release of node or something? Definitely doesn't seem related to this.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 5, 2024

LGTM!

I gather the spread test failures on Ubuntu 18.04 are related to a new release of node or something? Definitely doesn't seem related to this.

Correct, I need to make an issue for that unrelated node failure.

@mr-cal mr-cal enabled auto-merge (squash) January 5, 2024 13:52
@mr-cal mr-cal disabled auto-merge January 5, 2024 13:53
@mr-cal mr-cal merged commit 4aa5f63 into hotfix/7.5 Jan 5, 2024
12 of 14 checks passed
@mr-cal mr-cal deleted the build-base-deprecation-warning branch January 5, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants