chore: cherry-pick fixes to hotfix/8.3 #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a spread test for `edit-validation-sets` and `list-validation-sets`. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
- Use the correct data types for API calls - Switch to pydantic models - Catch model errors locally rather than relying on the store to validate the data - Make the boilerplate validation set valid Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
lengau
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Snapcraft 8.4 is delayed due to #4884 and https://forum.snapcraft.io/t/kde-global-auto-connect-qt-common-themes/40878/15.
In the interim, we need an 8.3.2 release.
This PR cherry-picks 2 hotfixes and 2 test updates from
main. The test updates will fix the failing CI in #4946.