fix: configure icon for snaps without apps #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/icons-fix
branch
2 times, most recently
from
85d04c9
to
5314fa3
Compare
lengau
approved these changes
Aug 1, 2024
|
This needs to be retargeted onto hotfix/7, which requires some maintenance: #4954 |
4 tasks
cmatsuoka
approved these changes
Aug 9, 2024
Always configure and install icons for snaps even if they do not have any `apps` defined in their `snapcraft.yaml` file. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Always configure and install icons for snaps even if they do not have any
appsdefined in theirsnapcraft.yamlfile.This looks like a regression introduced in core22 here based on this legacy code.
Fixes #4936
(CRAFT-3189)