Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: migrate to pydantic 2 #4955

Merged
merged 4 commits into from
Aug 15, 2024
Merged

chore!: migrate to pydantic 2 #4955

merged 4 commits into from
Aug 15, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Aug 6, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Migrate to Pydantic 2.

Fixes #4941
(CRAFT-3159)

@mr-cal mr-cal marked this pull request as draft August 6, 2024 16:59
@mr-cal mr-cal force-pushed the work/CRAFT-3159/pydantic-2 branch 3 times, most recently from f193784 to 953cb59 Compare August 8, 2024 15:08
@mr-cal mr-cal changed the base branch from main to feature/pydantic-2 August 8, 2024 15:09
@mr-cal mr-cal force-pushed the work/CRAFT-3159/pydantic-2 branch 2 times, most recently from 39486c3 to 09f9282 Compare August 8, 2024 16:04
@mr-cal mr-cal changed the base branch from feature/pydantic-2 to main August 8, 2024 21:01
@mr-cal mr-cal force-pushed the work/CRAFT-3159/pydantic-2 branch from 09f9282 to 86f261c Compare August 8, 2024 21:05
@mr-cal mr-cal force-pushed the work/CRAFT-3159/pydantic-2 branch 2 times, most recently from d9a9c43 to f481f49 Compare August 8, 2024 21:30
@mr-cal
Copy link
Collaborator Author

mr-cal commented Aug 8, 2024

This is ready for review, the tests started failing because @lengau is mid-flight in library releases

@mr-cal mr-cal requested review from lengau and tigarmo August 8, 2024 22:04
@mr-cal mr-cal changed the title [DRAFT] chore!: migrate to pydantic 2 chore!: migrate to pydantic 2 Aug 8, 2024
@mr-cal mr-cal marked this pull request as ready for review August 8, 2024 22:17
tigarmo
tigarmo approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

snapcraft/models/project.py Outdated Show resolved Hide resolved
snapcraft/parts/plugins/conda_plugin.py Show resolved Hide resolved
tests/unit/models/test_projects.py Show resolved Hide resolved
lengau
lengau requested changes Aug 9, 2024
View reviewed changes
snapcraft/linters/base.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
snapcraft/meta/snap_yaml.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
snapcraft/snap_config.py Outdated Show resolved Hide resolved
snapcraft_legacy/storeapi/v2/validation_sets.py Outdated Show resolved Hide resolved
snapcraft_legacy/storeapi/v2/validation_sets.py Outdated Show resolved Hide resolved
tests/unit/models/test_projects.py Outdated Show resolved Hide resolved
tests/unit/parts/plugins/test_conda_plugin.py Outdated Show resolved Hide resolved
@mr-cal
Copy link
Collaborator Author

mr-cal commented Aug 12, 2024

After this is approved, I'll re-organize and force-push the changes in a series of nice commits.

@mr-cal mr-cal requested a review from lengau August 12, 2024 19:39
@mr-cal mr-cal mentioned this pull request Aug 14, 2024
Closed
lengau
lengau approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

setup.py Outdated Show resolved Hide resolved
@mr-cal
Copy link
Collaborator Author

mr-cal commented Aug 14, 2024

Forced push to clean up commits before a rebase-merge

@mr-cal
build(deps)!: use pydantic 2, freeze requirements
8c685fd 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
chore!: update to craft-parts 2.0.0
ecaa1be 
craft-parts 2.0.0 uses debian architectures

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
chore: update to craft-providers 2.0.0
6cc802d 
craft-providers 2.0.0 removes the deprecated `build-base` parameter when
launching instances.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
chore!: update to pydantic 2.8.2
49ba2d9 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal added the rebase label Aug 15, 2024
@mr-cal mr-cal merged commit d0dec23 into main Aug 15, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3159/pydantic-2 branch August 15, 2024 14:08
@mr-cal mr-cal mentioned this pull request Sep 18, 2024
Closed
@mr-cal mr-cal mentioned this pull request Oct 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Pydantic 2
3 participants
@mr-cal @tigarmo @lengau