-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(application): commands, pre-run validation #5007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
commented
Aug 29, 2024
mr-cal
force-pushed
the
work/CRAFT-3106/command-refactor
branch
from
August 29, 2024 13:46
2c57004
to
a4ca44f
Compare
mr-cal
force-pushed
the
work/CRAFT-3106/command-refactor
branch
from
August 29, 2024 15:32
a4ca44f
to
5ab9475
Compare
mr-cal
commented
Aug 29, 2024
mr-cal
force-pushed
the
work/CRAFT-3106/command-refactor
branch
3 times, most recently
from
August 30, 2024 14:02
6279969
to
3cb2e1f
Compare
tigarmo
requested changes
Sep 2, 2024
tigarmo
approved these changes
Sep 4, 2024
CommandGroups can be used now that craft-application will accept a sequence of commands. See canonical/craft-application#359 Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3106/command-refactor
branch
from
September 4, 2024 19:39
48d8d63
to
4403441
Compare
cmatsuoka
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Refactor
command_groups
property, except for theLifecycleGroup
_get_dispatcher()
code into 2 places:ClassicFallback
errors before creating the dispatcherCraftErrors
if the wrong codepath or wrong version of snapcraft was chosen after creating the dispatcherUX changes
SNAPCRAFT_REMOTE_BUILD_STRATEGY
show a properly formatted error instead of a tracebackSNAPCRAFT_REMOTE_BUILD_STRATEGY
is only validated when executingsnapcraft remote-build
SNAPCRAFT_REMOTE_BUILD_STRATEGY
is validated for core24 and newer snaps, rather than being ignored.snapcraft list-plugins --base=core20
no longer fails in a core24 project directory (snapcraft list-plugins --base=core20
fails in a core24 project directory #5008)Fixes #4911
Fixes #5008
(CRAFT-3106)