fix(remotebuild): do not auto clean interrupted builds #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
requested review from
a team,
lengau and
mattculler
and removed request for
a team
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3140/cancel-remote-builds
branch
from
7c36d52
to
53e76a2
Compare
lengau
approved these changes
Oct 1, 2024
mattculler
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Fixes a bug where the remote builder would ignore the user and always clean the launchpad project.
Also drops some magic values in favor of constants.
(CRAFT-3140)
Fixes #4929