Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: simplifies the platform plug #5109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soumyaDghosh
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

This PR simplifies the desktop command chain approach, also adds support for separate Platform plug which was also used previously.

Better to merge this before #5092

@mr-cal mr-cal requested a review from lengau October 15, 2024 14:21
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScarlettGatelyMoore dropped the "make-parameters": ["PLATFORM_PLUG=... lines yesterday in d1c5ecb#diff-8a03e9a3b9e1e0cfa55b428426f2adc16394d075e8adf80c3f487022e02bb4f6L701.

Is PLATFORM_PLUG and this PR still needed or can it be dropped?

@mr-cal mr-cal removed the request for review from lengau October 15, 2024 14:38
@soumyaDghosh
Copy link
Contributor Author

soumyaDghosh commented Oct 15, 2024

@ScarlettGatelyMoore dropped the "make-parameters": ["PLATFORM_PLUG=... lines yesterday in d1c5ecb#diff-8a03e9a3b9e1e0cfa55b428426f2adc16394d075e8adf80c3f487022e02bb4f6L701.

Is PLATFORM_PLUG and this PR still needed or can it be dropped?

PLATFORM_PLUG that she was using i.e PLATFORM_PLUG=runtime snap name isn't used anymore, this PR reintroduces it in a different way. I did suggested the changes that were needed to make this PR work with #5092 , but it probably got things complicated on her side. So, I think better to wait, and once her PR is ready, I can rework on things. This PR basically removes the hardcoded gnome-platform path in the command-chain from here and make the path configurable.

EDIT: @jardon tried to do the same thing in this PR.

@mr-cal
Copy link
Collaborator

mr-cal commented Oct 15, 2024

Waiting on #5092 to land first sounds like a good plan. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants