Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlord: start turning restart into a full state manager #12166

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

pedronis
Copy link
Collaborator

later this will allow to add a StartUp method to handle held tasks waiting for a reboot

later this will allow to add a StartUp method to handle held
tasks waiting for a reboot
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, this looks fine.

Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedronis pedronis merged commit 7b37d59 into canonical:master Sep 21, 2022
@pedronis pedronis deleted the restart-as-manager branch September 21, 2022 18:18
benhoyt added a commit to benhoyt/pebble that referenced this pull request Jul 11, 2024
This is based on canonical/snapd#12166 (though
the diff was applied more or less manually, as the patch couldn't be
applied directly).

It includes the name changes to the restart.Handler interface methods.
benhoyt added a commit to canonical/pebble that referenced this pull request Jul 17, 2024
This is based on canonical/snapd#12166 (though
the diff was applied more or less manually, as the patch couldn't be
applied directly).

It includes the name changes to the restart.Handler interface methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants