Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many: make snap pack --check-skeleton error logs consistent #14547

Merged
merged 5 commits into from
Oct 1, 2024
Merged

many: make snap pack --check-skeleton error logs consistent #14547

merged 5 commits into from
Oct 1, 2024

Commits on Sep 27, 2024

  1. many: make snap pack --check-skeleton error logs consistent 

    This fixes inconsistencies in "snap pack --check-skeleton" error
logs consistent.

- shows detailed logs only if SNAPD_DEBUG is set.
- returns first error caught

It should be explored how to aggregate errors with consistency
in mind as this is parsed by snapcraft.

Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
    @ZeyadYasser
    ZeyadYasser committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7c543cb View commit details
    Browse the repository at this point in the history

  2. snap/pack/pack_test.go: adjust tested file permissions 

    Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
    @ZeyadYasser
    ZeyadYasser committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a195b7e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. snap: add error type checks in unit tests 

    Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
    @ZeyadYasser
    ZeyadYasser committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e0c053f View commit details
    Browse the repository at this point in the history

  2. snap/pack: revert to Noticef logger to avoid regressions 

    Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
    @ZeyadYasser
    ZeyadYasser committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    919676a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. cmd/snap: fix flakey TestPackPacksFailsForMissingPaths test 

    Signed-off-by: Zeyad Gouda <zeyad.gouda@canonical.com>
    @ZeyadYasser
    ZeyadYasser committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    30aac23 View commit details
    Browse the repository at this point in the history