Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: test snapdusergo tag #14550

Merged

Conversation

valentindavid
Copy link
Contributor

Follow up for #13776

@valentindavid valentindavid added this to the 2.66 milestone Sep 30, 2024
@valentindavid valentindavid marked this pull request as ready for review September 30, 2024 12:09
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (ac897ee) to head (5e3c4e4).
Report is 47 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #14550    +/-   ##
========================================
  Coverage   78.85%   78.86%            
========================================
  Files        1079     1083     +4     
  Lines      145615   145971   +356     
========================================
+ Hits       114828   115118   +290     
- Misses      23601    23659    +58     
- Partials     7186     7194     +8     
Flag Coverage Δ
unittests 78.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestl ernestl self-requested a review September 30, 2024 12:24
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl
Copy link
Collaborator

ernestl commented Sep 30, 2024

I made these required for master branch

@valentindavid
Copy link
Contributor Author

This is not supposed to affect other distros than Ubuntu or Debian (unless we have tests for re-execution for other distros, but I do not think we have that yet).

@ernestl ernestl merged commit 0d7c868 into canonical:master Oct 1, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants