secboot: register keys in keyring with also the legacy paths #14718
+21
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
added
Run nested
valentindavid
force-pushed
the
valentindavid/keyring-legacy-paths
branch
2 times, most recently
from
000f73a
to
fca73da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14718 +/- ##
=======================================================
Coverage ? 78.83%
=======================================================
Files ? 1093
Lines ? 147820
Branches ? 0
=======================================================
Hits ? 116541
Misses ? 24002
Partials ? 7277
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
github-actions
bot
added
the
Run Nested -auto-
valentindavid
force-pushed
the
valentindavid/keyring-legacy-paths
branch
from
88965fe
to
e952017
Compare
snap-bootstrap use to unlock encrypted disks using /dev/disk/by-partuuid paths. This was used ask identifier for the keys stored in the keyring. However /dev/disk/by-uuid path makes more sense as UUID is a part of LUKS2, and cryptsetup uses it for the identify of the volume key. Partition UUID on the other hand are only for GPT partitions. However older snapd will query the key using the old path. So we need to make sure snap-bootstrap also register the old name. A new snap-bootstrap should always be able to run and older snapd.
valentindavid
force-pushed
the
valentindavid/keyring-legacy-paths
branch
from
e952017
to
f8e1909
Compare
ernestl
merged commit 5f5f773
into
canonical:fde-manager-features
43 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snap-bootstrap use to unlock encrypted disks using /dev/disk/by-partuuid paths. This was used ask identifier for the keys stored in the keyring. However /dev/disk/by-uuid path makes more sense as UUID is a part of LUKS2, and cryptsetup uses it for the identify of the volume key. Partition UUID on the other hand are only for GPT partitions.
However older snapd will query the key using the old path. So we need to make sure snap-bootstrap also register the old name. A new snap-bootstrap should always be able to run and older snapd.