run-checks,.golangci.yml: move checks from run-checks to lints #14721
Conversation
Move the checks for `math/rand` and `io/ioutil` from run-checks to lints defined for golangci-lint. Also, enable the gofmt lint, now that we're on go version 1.13+. Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
|
The |
| @@ -183,8 +195,7 @@ linters: | |||
| # gosimple may suggest patterns that work only with more recent Go versions | |||
| # - gosimple | |||
| - nakedret | |||
| # formatting is disabled until we move to Go 1.13 | |||
| # - gofmt | |||
| - gofmt | |||
There was a problem hiding this comment.
Does this nullify the need for separate fmt checks in run-checks?
There was a problem hiding this comment.
let's double check, there's likely more linters we have in run-checks that may not be needed anymore
There was a problem hiding this comment.
The manual one in run-checks runs with -s -d, which prints out a nice diff, whereas the one in golangci-lint only supports -s. So the former is what we're used to and is nicer.
Regarding other lints, I did check, and some of the others in run-checks apply to all files, while the golangci-lint checks only seem to apply to .go files. So technically I think we want to preserve the superset of checks in run-checks in some cases.
I don't think we need nakedret in run-checks anymore, though.
| @@ -183,8 +195,7 @@ linters: | |||
| # gosimple may suggest patterns that work only with more recent Go versions | |||
| # - gosimple | |||
| - nakedret | |||
| # formatting is disabled until we move to Go 1.13 | |||
| # - gofmt | |||
| - gofmt | |||
There was a problem hiding this comment.
let's double check, there's likely more linters we have in run-checks that may not be needed anymore
There was a problem hiding this comment.
The check in run-checks is failing and it's picking up .golangci.yml and run-checks files (insert spiderman pointing at spiderman meme). Maybe it's because of the removal of the lowercase exception, although we could just remove the run-checks misspell check altogether since we have the other one
.golangci.yml:155:8: "PROCES" is a misspelling of "PROCESS"
.golangci.yml:156:8: "PROCESSS" is a misspelling of "PROCESSES"
cmd/snap-seccomp/main_test.go:637:21: "PROCES" is a misspelling of "PROCESS"
cmd/snap-seccomp/main_test.go:637:81: "PROCES" is a misspelling of "PROCESS"
cmd/snap-seccomp/main_test.go:638:21: "PROCESSS" is a misspelling of "PROCESSES"
cmd/snap-seccomp/main_test.go:638:83: "PROCESSS" is a misspelling of "PROCESSES"
run-checks:272:10: "PROCES" is a misspelling of "PROCESS"
run-checks:272:52: "PROCES" is a misspelling of "PROCESS"
run-checks:275:32: "PROCES" is a misspelling of "PROCESS"
run-checks:275:39: "PROCESSS" is a misspelling of "PROCESSES"
Move the checks for
math/randandio/ioutilfrom run-checks to lints defined for golangci-lint.Also, enable the gofmt lint, now that we're on go version 1.13+.