Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/devicestate: remodeling with components #14878

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewphelpsj
Copy link
Member

Drafting for now just to run some spread tests.

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 68.95522% with 104 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (24a0034) to head (804f0d8).
Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
overlord/devicestate/devicestate.go 68.19% 84 Missing and 20 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14878      +/-   ##
==========================================
+ Coverage   78.20%   78.26%   +0.05%     
==========================================
  Files        1151     1160       +9     
  Lines      151396   152656    +1260     
==========================================
+ Hits       118402   119475    +1073     
- Misses      25662    25809     +147     
- Partials     7332     7372      +40     
Flag Coverage Δ
unittests 78.26% <68.95%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewphelpsj andrewphelpsj added the Run nested The PR also runs tests inluded in nested suite label Dec 19, 2024
@andrewphelpsj andrewphelpsj reopened this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant