tests, simpleget: replace use of test-snapd-curl with simpleget where possible, support request headers #14884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
force-pushed
the
bboozzoo/use-simpleget
branch
from
eea4557 to
f47a997
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14884 +/- ##
==========================================
+ Coverage 78.20% 78.29% +0.08%
==========================================
Files 1151 1154 +3
Lines 151396 152620 +1224
==========================================
+ Hits 118402 119491 +1089
- Misses 25662 25758 +96
- Partials 7332 7371 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
approved these changes
Dec 19, 2024
tests/lib/tools/simpleget
Outdated
| if opts.header: | ||
| for hdr in opts.header: | ||
| sp = hdr.split(": ") | ||
| if len(sp) != 2: |
There was a problem hiding this comment.
I would use str.partition https://docs.python.org/3/library/stdtypes.html#str.partition which is somewhat like strings.Cut in Go
Add support for setting request headers using curl-like syntax. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
Replace uses of test-snapd-curl with simpleget in an attempt to reduce the number of external dependencies installed by the tests. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/use-simpleget
branch
from
7f15512 to
deb25c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for setting request headers to simpleget and replace uses of test-snapd-curl with simpleget in an attempt to reduce the number of external dependencies installed by the tests.
Related: SNAPDENG-34225
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?