tests: remove snapd in ubuntu-core-snapd #8129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragons ahead This patch fixes `ubuntu-core-16` machines from running with a leaked snapd snap leftovers after the `tests/main/ubuntu-core-snapd` test. Such leak is picked up by `tests/regression/lp-1805838` test and has been seen to fail several times today. The test abuses the fact that any broken snap can be removed! Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
fix/ubuntu-core-snapd-restore
branch
from
7c5c2fc
to
1725fc1
Compare
anonymouse64
approved these changes
Feb 13, 2020
bboozzoo
approved these changes
Feb 13, 2020
| @@ -29,7 +29,10 @@ execute: | | |||
| # we cannot restore in "restore:" because we need a reboot | |||
| # right now to get a clean state again | |||
| systemctl stop snapd.service snapd.socket snapd.autoimport.service snapd.snap-repair.service | |||
There was a problem hiding this comment.
Can you add snapd.snap-repair.timer here too?
|
Travis build failed here on OSX build, I've restarted it, but here is the log for interested parties: https://pastebin.ubuntu.com/p/Y9qkgBKPsS/ I think the root cause is a network error but I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragons ahead
This patch fixes
ubuntu-core-16machines from running with a leakedsnapd snap leftovers after the
tests/main/ubuntu-core-snapdtest. Suchleak is picked up by
tests/regression/lp-1805838test and has beenseen to fail several times today.
The test abuses the fact that any broken snap can be removed!
Signed-off-by: Zygmunt Krynicki me@zygoon.pl