Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: enable ubuntu 21.04 for spread tests #9792

Merged
merged 18 commits into from
Feb 17, 2021
Merged

tests: enable ubuntu 21.04 for spread tests #9792

merged 18 commits into from
Feb 17, 2021

Conversation

sergiocazzolato
Copy link
Collaborator

New image available.
Minor changes to make tests pass.

mvo5
mvo5 reviewed Dec 11, 2020
View reviewed changes
tests/main/lxd-mount-units/task.yaml Outdated
@@ -5,7 +5,8 @@ details: |
are correct for snapfuse.

# only 20.04+, we want lxd images that come with snaps preinstalled.
systems: [ubuntu-2*]
# TODO: enable for ubuntu-21.04-64 when the ñxd image is available
systems: [ubuntu-2*, -ubuntu-21.04-64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately spread does not support mixing systems and negation of systems :/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed
Thanks

stolowski
stolowski reviewed Dec 14, 2020
View reviewed changes
tests/lib/nested.sh
Comment on lines +217 to +218
ubuntu-21.04-64*)
echo "https://cloud-images.ubuntu.com/hirsute/current/hirsute-server-cloudimg-amd64.img"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21.04 needs to be enabled in nested suites for this to have an effect right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already deployed the image to the gce bucket, with that it should be enough. It is because we source this script and it uses the current system independently of the suite being executed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stolowski, I still I see preseed tests failing with this error, any idea about how to fix it?

2020-12-12 13:18:09 (108 MB/s) - ‘cloudimg.img’ saved [563871744/563871744]

  • mkdir -p /mnt/cloudimg
  • . /home/gopath/src/github.com/snapcore/snapd/tests/lib/preseed.sh
    ++ pwd
  • mount_ubuntu_image /home/gopath/src/github.com/snapcore/snapd/tests/main/preseed/cloudimg.img /mnt/cloudimg
  • local CLOUD_IMAGE=/home/gopath/src/github.com/snapcore/snapd/tests/main/preseed/cloudimg.img
  • local IMAGE_MOUNTPOINT=/mnt/cloudimg
  • grep nbd
  • lsmod
  • modprobe nbd
    ++ command -v qemu-nbd
  • systemd-run --system --service-type=forking --unit=qemu-nbd-preseed.service '' --fork -c /dev/nbd0 /home/gopath/src/github.com/snapcore/snapd/tests/main/preseed/cloudimg.img
    Failed to find executable : No such file or directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I need to investigate to see what changed on 21.04. By the way, I think we should add 'Run nested' to this PR (and close/re-open)?

@bboozzoo bboozzoo added the Run nested The PR also runs tests inluded in nested suite label Jan 4, 2021
@bboozzoo bboozzoo closed this Jan 4, 2021
@bboozzoo bboozzoo reopened this Jan 4, 2021
mvo5
mvo5 reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. Code change looks fine now. Let's see how the tests are doing.

@bboozzoo
Copy link
Contributor

bboozzoo commented Jan 4, 2021

Uh, we'll need to merge master once #9806 lands

@bboozzoo
Copy link
Contributor

bboozzoo commented Jan 4, 2021

I've merged latest master now.

@bboozzoo
Copy link
Contributor

bboozzoo commented Jan 4, 2021 

2021-01-04 09:35:44 Failed tasks: 1
    - google:ubuntu-21.04-64:tests/main/cohorts
2021-01-04 09:35:44 Failed task prepare: 2
    - google:ubuntu-21.04-64:tests/main/preseed
    - google:ubuntu-21.04-64:tests/main/preseed-reset

cohorts is fixed is #9807

@anonymouse64
Copy link
Contributor

this could probably use a master merge

@bboozzoo
Copy link
Contributor

merged master and pushed

@mvo5 mvo5 added the Squash-merge Please squash this PR when merging. label Feb 8, 2021
mvo5
mvo5 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get 21.04 into our CI (even if some tests fail, it's not mandatory yet)

@anonymouse64
Copy link
Contributor

Mmm, this still seems unhappy...

2021-02-08 10:25:33 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720019): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720019)
2021-02-08 10:25:34 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720190): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720190)
2021-02-08 10:25:34 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720199): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720199)
2021-02-08 10:25:35 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720205): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720205)
2021-02-08 10:25:35 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720210): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720210)
2021-02-08 10:25:35 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720214): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720214)
2021-02-08 10:25:36 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720218): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720218)
2021-02-08 10:25:36 Cannot allocate google:ubuntu-21.04-64: cannot allocate new Google server google:ubuntu-21.04-64 (feb081022-720223): cannot find ready marker in console output for google:ubuntu-21.04-64 (feb081022-720223)

I retried it to see if that was just a transient thing though

@github-actions github-actions bot removed the Run nested The PR also runs tests inluded in nested suite label Feb 17, 2021
@sergiocazzolato sergiocazzolato merged commit 54f6401 into canonical:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stolowski stolowski stolowski left review comments

@mvo5 mvo5 mvo5 approved these changes

Assignees
No one assigned
Labels
Squash-merge Please squash this PR when merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sergiocazzolato @bboozzoo @anonymouse64 @stolowski @mvo5