backends: LXD: fix SSH login for ubuntu-22.04 #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue in other backends, probably we should align with those: |
thp-canonical
force-pushed
the
lxd-ubuntu-22.04-tune-ssh
branch
2 times, most recently
from
b0438af to
c6220b5
Compare
thp-canonical
force-pushed
the
lxd-ubuntu-22.04-tune-ssh
branch
from
c6220b5 to
3954505
Compare
|
I'm interested in this fix. It sounds like it could fix the spread test issue we're seeing in Netplan's CI: |
ZeyadYasser
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Thank you for catching this, Maybe let's wait for the fix to be merged in the google backend #155? and then backport it to all other providers so that the fix is consistent across all of them.
ZeyadYasser
reviewed
Mar 25, 2024
Co-authored-by: Zeyad Yasser <zeyady98@gmail.com>
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
5 tasks
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
slyon
added a commit
to canonical/netplan
that referenced
this pull request
May 21, 2024
daniloegea
pushed a commit
to canonical/netplan
that referenced
this pull request
Jul 3, 2024
|
Hi, Thanks! |
cmatsuoka
reviewed
Sep 3, 2024
| @@ -482,6 +482,8 @@ func (p *lxdProvider) serverJSON(name string) (*lxdServerJSON, error) { | |||
| func (p *lxdProvider) tuneSSH(name string) error { | |||
| cmds := [][]string{ | |||
| {"sed", "-i", `s/^\s*#\?\s*\(PermitRootLogin\|PasswordAuthentication\)\>.*/\1 yes/`, "/etc/ssh/sshd_config"}, | |||
| {"/bin/bash", "-c", `sed -i 's/^\s*\(PermitRootLogin\|PasswordAuthentication\)\>.*/# COMMENTED OUT BY SPREAD: \0/' /etc/ssh/sshd_config.d/* || true`}, | |||
There was a problem hiding this comment.
The SSH daemon uses the first value it finds for a given configuration entry if it appears multiple times, so just adding the 00 line below should be enough?
|
Superseded by #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that SSH login wouldn't work after a ubuntu-22.04 image is deployed.
While
tuneSSH()tries to setPasswordAuthenticationtoyesin/etc/ssh/sshd_config, Ubuntu 22.04 images in LXD have a file/etc/ssh/sshd_config.d/60-cloudimg-settings.confthat contains "PasswordAuthentication no", and this file is sourced by/etc/ssh/sshd_config.Fix this by also
seding all files matching/etc/ssh/sshd_config.d/*, but ignore failures of this command, as Ubuntu 20.04 and older don't have/etc/ssh/sshd_config.d(or files that match the glob above).Related links: https://superuser.com/a/1828947