Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: use new Mesa from kisak PPA, and generate ld.so.cache #33

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

jhenstridge
Copy link
Contributor

@jhenstridge jhenstridge commented Jul 14, 2022

(this is @ashuntu's mesa-kisak branch. I'm opening the PR so I can add some review comemnts)

  • Add the kisak/kisak-mesa PPA to the build so we can provide a more recent Mesa.
  • Add a post-refresh hook that generates an /etc/ld.so.cache file so that games that stomp over LD_LIBRARY_PATH can still find libraries provided by the snap

Fixes #19

ashuntu and others added 2 commits July 12, 2022 18:02
…ed for PPA

Snapcraft only enables the amd64 version by default, and doesn't offer a
way to change that with the short ppa syntax. So this also involves
switching to the longer syntax.

While we're at it, convert the steam repo to use package-repositories too.
Copy link
Contributor Author

@jhenstridge jhenstridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think we can remove the references to $RUNTIME in the post-refresh hook though.

Comment on lines 28 to 35
$RUNTIME/lib/x86_64-linux-gnu
$RUNTIME/lib/i386-linux-gnu
$RUNTIME/lib
$RUNTIME/usr/lib/x86_64-linux-gnu
$RUNTIME/usr/lib/i386-linux-gnu
$RUNTIME/usr/lib
$RUNTIME/usr/lib/x86_64-linux-gnu/dri
$RUNTIME/usr/lib/i386-linux-gnu/dri
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines can be removed, since this snap isn't using the gnome platform snap.

@ashuntu ashuntu requested review from ashuntu and removed request for ashuntu July 14, 2022 17:19
Copy link
Collaborator

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhenstridge jhenstridge merged commit 3b7c325 into main Jul 15, 2022
@ashuntu ashuntu deleted the mesa-kisak branch May 2, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to launch game due to missing libraries
3 participants