Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMTP via the smtp-integrator charm #127

Merged
merged 49 commits into from
Jan 8, 2024
Merged

Add SMTP via the smtp-integrator charm #127

merged 49 commits into from
Jan 8, 2024

Commits on Dec 12, 2023

  1. Rename smtp_notif_from config to notif_from

    @javierdelapuente
    javierdelapuente committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2c912c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. WIP add smtp integrator with unit tests

    @javierdelapuente
    javierdelapuente committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4a8cec8 View commit details
    Browse the repository at this point in the history

  2. Integration tests for smtp integrator

    @javierdelapuente
    javierdelapuente committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2e7a2c1 View commit details
    Browse the repository at this point in the history

  3. Check relation exists

    @javierdelapuente
    javierdelapuente committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2915aea View commit details
    Browse the repository at this point in the history

  4. Disable smtp with secrets test

    @javierdelapuente
    javierdelapuente committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ad0cbda View commit details
    Browse the repository at this point in the history

  5. Fix linter

    @javierdelapuente
    javierdelapuente committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7358013 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Revert integration test with secrets and juju 3.1

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ed72e9c View commit details
    Browse the repository at this point in the history

  2. Revert juju version in integration tests

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3befa41 View commit details
    Browse the repository at this point in the history

  3. Revert juju version to 2.9.45

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    404c585 View commit details
    Browse the repository at this point in the history

  4. Disable self host runner temporarily until they have yq

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    e3f1a7f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ISD-1443-smtp-via-integrator-charm

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a4e84fd View commit details
    Browse the repository at this point in the history

  6. Fix integration test and parameterise it

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ca8562b View commit details
    Browse the repository at this point in the history

  7. Include smtp integration in the documentation

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    82f590b View commit details
    Browse the repository at this point in the history

  8. Set smtp integration as optional

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d00595f View commit details
    Browse the repository at this point in the history

  9. Try to fix integration test error because of empty databag

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9bc3857 View commit details
    Browse the repository at this point in the history

  10. Improve test info in act

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    19b832e View commit details
    Browse the repository at this point in the history

  11. Put the self hosted runners back

    @javierdelapuente
    javierdelapuente committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    01efb6c View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Update year for license

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    4e1b67a View commit details
    Browse the repository at this point in the history

  2. Add log when smtp databag is empty

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    34c5118 View commit details
    Browse the repository at this point in the history

  3. Defer the event if it cannot be processed when enabling smtp

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e898ddb View commit details
    Browse the repository at this point in the history

  4. defered -> deferred

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    dd11e6b View commit details
    Browse the repository at this point in the history

  5. Update SMTPConfiguration to be a dataclass

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    016653d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ISD-1443-smtp-via-integrator-charm

    @javierdelapuente
    javierdelapuente committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7c241b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Remove defer in enable smtp in observer

    @javierdelapuente
    javierdelapuente committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7682b5a View commit details
    Browse the repository at this point in the history

  2. Improve working of notif_from description

    @javierdelapuente
    javierdelapuente committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    162c7e3 View commit details
    Browse the repository at this point in the history

  3. Remove use of test manual secret to secrets.token_hex

    @javierdelapuente
    javierdelapuente committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4b268f6 View commit details
    Browse the repository at this point in the history

  4. Removed unnecessary shebang

    @javierdelapuente
    javierdelapuente committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3e759f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Remove extra space 

    Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com>
    @javierdelapuente @yanksyoon
    javierdelapuente and yanksyoon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e190d85 View commit details
    Browse the repository at this point in the history

  2. Update integrations tests to juju 3 and test secrets in smtp

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    29adb24 View commit details
    Browse the repository at this point in the history

  3. Update smtp library

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3586891 View commit details
    Browse the repository at this point in the history

  4. rename method to get default notif_from value 

    Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com>
    @javierdelapuente @yanksyoon
    javierdelapuente and yanksyoon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a2613ef View commit details
    Browse the repository at this point in the history

  5. add removed src-docs

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a04ea5e View commit details
    Browse the repository at this point in the history

  6. test juju 3 extra arguments to see if it works

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a48bcad View commit details
    Browse the repository at this point in the history

  7. Try to see if another version of microk8s work

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1ad6e1a View commit details
    Browse the repository at this point in the history

  8. Trying microk8s 1.29-strict

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e8aeb56 View commit details
    Browse the repository at this point in the history

  9. let's see if it works hosted runners

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0a7a475 View commit details
    Browse the repository at this point in the history

  10. Try with microk8s 1.28

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b74287e View commit details
    Browse the repository at this point in the history

  11. change mjolnir channel to stable

    @javierdelapuente
    javierdelapuente committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4da1228 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Remove commented code

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    afd7bb4 View commit details
    Browse the repository at this point in the history

  2. Revert mjolnir to edge as it is working again

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    cd1b1ef View commit details
    Browse the repository at this point in the history

  3. Put smtp configuration in howto instead of tutorial

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1488b98 View commit details
    Browse the repository at this point in the history

  4. Use function for parameter to test function

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2440393 View commit details
    Browse the repository at this point in the history

  5. Comment in pylint: disable=too-many-instance-attributes

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    dcf0b0a View commit details
    Browse the repository at this point in the history

  6. removed hardcoded secret in test

    @javierdelapuente
    javierdelapuente committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7cdce56 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Fail on unsecure SMTP configurations

    @javierdelapuente
    javierdelapuente committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3b5f906 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ISD-1443-smtp-via-integrator-charm

    @javierdelapuente
    javierdelapuente committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    eb76d4e View commit details
    Browse the repository at this point in the history

  3. Update doc to explain invalid smtp configurations

    @javierdelapuente
    javierdelapuente committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1b6de53 View commit details
    Browse the repository at this point in the history

  4. typo. unsecure -> insecure

    @javierdelapuente
    javierdelapuente committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    02b2454 View commit details
    Browse the repository at this point in the history

  5. Fix integration test. Use tls in smtp

    @javierdelapuente
    javierdelapuente committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5a7e105 View commit details
    Browse the repository at this point in the history