Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ISD-847): Prevent server_name to be changed #8

Merged
merged 14 commits into from
Jun 29, 2023

Conversation

amandahla
Copy link
Collaborator

@amandahla amandahla commented Jun 21, 2023

Prevent server_name to be change by comparing with the one in the configuration file if exists.

@amandahla amandahla requested a review from a team as a code owner June 21, 2023 20:25
@amandahla amandahla marked this pull request as draft June 21, 2023 20:25
src/constants.py Outdated Show resolved Hide resolved
src/synapse.py Outdated Show resolved Hide resolved
@amandahla amandahla changed the title WIP - feat(ISD-847): Prevent server_name to be changed feat(ISD-847): Prevent server_name to be changed Jun 26, 2023
@amandahla amandahla marked this pull request as ready for review June 26, 2023 20:29
actions.yaml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/synapse.py Outdated Show resolved Hide resolved
src/synapse.py Outdated Show resolved Hide resolved
src/synapse.py Show resolved Hide resolved
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/unit/conftest.py Outdated Show resolved Hide resolved
tests/unit/conftest.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
actions.yaml Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/synapse.py Show resolved Hide resolved
src/synapse.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

Test coverage for d7e3bb5

Name                 Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------
src/charm.py            62      2      6      1    96%   118-119
src/charm_state.py      38      2     10      2    92%   22, 63
src/charm_types.py       6      0      0      0   100%
src/constants.py        10      0      0      0   100%
src/exceptions.py       10      0      0      0   100%
src/synapse.py          58      2      8      1    95%   133-138
----------------------------------------------------------------
TOTAL                  184      6     24      4    95%

Static code analysis report

Run started:2023-06-28 18:59:25.616224

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 975
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amandahla amandahla merged commit 400c31d into main Jun 29, 2023
@amandahla amandahla deleted the ISD-847-synapse-prevent-server-name-to-be-changed branch June 29, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants