chore: bump minimum Go version in go.mod to 1.21 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsander-souza
force-pushed
the
refresh_go_mod
branch
from
ae748d2 to
fd8bdf0
Compare
troyanov
requested changes
Aug 13, 2024
There was a problem hiding this comment.
TL;DR let's just bump min Go version (without toolchain directive)
FTR It seems we missed min Go version bump when updated bflad/tfproviderlint
go: github.com/bflad/tfproviderlint@v0.30.0 requires go@1.21, but 1.20 is requested
Setting the toolchain version to a different version than the min Go (language version) is useful in some rare cases. For example, if you want to compile the project with at least toolchain 1.22.6 but still want the language to be 1.21 (because for some reason you don't like the loop variable change).
So I think that in most cases there is no need to set toolchain version, as it's already implicitly set by the go directive.
troyanov
changed the title
alexsander-souza
force-pushed
the
refresh_go_mod
branch
from
fd8bdf0 to
9067115
Compare
troyanov
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.