Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include c3 link in the request body of the end-test API endpoint #126

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

andrejvelichkovski
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski commented Feb 19, 2024

Currently to send the C3 link we make an additional PATCH request to the /test-execution/ID endpoint. This introduces some extra network overhead, which is not necessary, as we already have the communication from C3 to TO with the end-test/ID endpoint. It resolves RTW-240.

This implementation adds the C3 link as an optional parameter in the request body of the end-test/ID/ endpoint. It is optional to ensure backwards compatibility with all clients making use of this API without sending the c3 link in the request body.

@andrejvelichkovski andrejvelichkovski marked this pull request as ready for review February 19, 2024 12:27
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrejvelichkovski andrejvelichkovski merged commit be2bd79 into main Feb 19, 2024
1 of 2 checks passed
@andrejvelichkovski andrejvelichkovski deleted the update-c3-link-in-end-test-endpoint branch February 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants