-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform provider backed Juju model setup + associated charmed operators for API and backend #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other minor comments. Also, please, make sure your changes don't rollback #14 PR
Note that pytest is failing. Imports need updating in tests directory |
Yes, all sorts of things break I imagine. As I keep stressing, CI needs improvements now, obviously we cannot collaborate effectively without knowing when linting, formatting, testing, building different artefacts breaks. That goes to frontend, backend, charms that operate them. All of this is best done in subsequent PRs because this PR introduces changes that will conflict will anything you would do with main now. |
To explain this the Nth time for posterity, the conflicts between main and this branch are down to there having been a number of PRs merged whilst this was in motion which move files under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my concerns were addressed and resolved. Thanks for these changes!
Introduces K8s backed deployment methodology using charms and terraform that builds out a Juju model with the application:
src
totest_observer
so that import paths work andpoetry build
actually works (building a wheel was necessary in order to get dynamic versioning working).Tested locally by multiple passes of setting up and tearing down the Juju model, reviewer should do the same following the steps in the README.