Test execution search and query params #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM! No complains about the code, but I will let @nadzyah also review the code and +1 it 😄
| @@ -13,38 +13,38 @@ class FindShortcut extends ConsumerWidget { | |||
|
|
|||
| @override | |||
| Widget build(BuildContext context, WidgetRef ref) { | |||
| final shouldActivateShortcut = AppRoutes.isAtDashboardPage(context); | |||
| final shouldMakeFiltersVisible = | |||
| AppRoutes.isDashboardPage(AppRoutes.uriFromContext(context)); | |||
There was a problem hiding this comment.
Just curious, do we want to bind ctrl+f to the search bar on each artefact page, or just in the dashboard page?
There was a problem hiding this comment.
ctrl+f does work on both pages now. This condition is to display the hidden filters on dashboard page
nadzyah
reviewed
Mar 21, 2024
Comment on lines
22
to
25
| return emptyArtefactFilters | ||
| .copyWithOptionsExtracted(artefacts) | ||
| .copyWithQueryParams(pageUri.queryParametersAll); | ||
| } else if (AppRoutes.isArtefactPage(pageUri)) { |
There was a problem hiding this comment.
I guess you don't need an else statement after return
Comment on lines
33
to
36
| return emptyTestExecutionFilters | ||
| .copyWithOptionsExtracted(testExecutions) | ||
| .copyWithQueryParams(pageUri.queryParametersAll); | ||
| } else { |
frontend/lib/routing.dart
Outdated
Comment on lines
75
to
76
| return uri.pathSegments[1].toInt(); | ||
| } else { |
nadzyah
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RTW-244 and closes #140 and #121
Changes:
Screencast.from.2024-03-20.15-07-31.webm