Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement artefacts promote endpoint for debs #15

Merged
merged 20 commits into from
Jun 13, 2023
Merged

Implement artefacts promote endpoint for debs #15

merged 20 commits into from
Jun 13, 2023

Conversation

nadzyah
Copy link
Collaborator

@nadzyah nadzyah commented May 31, 2023 •
edited
Loading

This PR resolves RTW-80

It includes the following changes:

  • simplifies the logic of the original deb manager script
  • contains the helpers for managing data from archive
  • unifies the promote_artefact function to work with any kind of artefact

@nadzyah
Copy link
Collaborator Author

nadzyah commented May 31, 2023

The testing is not done yet since I'm waiting for deb packages examples from @jocave

@nadzyah nadzyah requested a review from omar-selo June 1, 2023 07:47
@nadzyah nadzyah force-pushed the debmanager branch 2 times, most recently from 661d932 to 6aacc29 Compare June 1, 2023 11:14
@nadzyah nadzyah marked this pull request as ready for review June 5, 2023 13:38
omar-selo
omar-selo requested changes Jun 6, 2023
View reviewed changes
backend/test_observer/controllers/artefacts/artefacts.py Outdated Show resolved Hide resolved
backend/test_observer/controllers/artefacts/artefacts.py Outdated Show resolved Hide resolved
backend/test_observer/controllers/artefacts/artefacts.py Outdated Show resolved Hide resolved
backend/tests/controllers/artefacts/test_artefacts.py Outdated Show resolved Hide resolved
backend/test_observer/external_apis/archive.py Outdated Show resolved Hide resolved
backend/test_observer/external_apis/archive.py Outdated Show resolved Hide resolved
backend/test_observer/external_apis/archive.py Show resolved Hide resolved
@nadzyah nadzyah requested a review from omar-selo June 9, 2023 12:59
@nadzyah nadzyah requested a review from omar-selo June 13, 2023 10:52
omar-selo
omar-selo approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadzyah nadzyah merged commit 7076200 into main Jun 13, 2023
@nadzyah nadzyah deleted the debmanager branch June 13, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mz2 mz2 mz2 left review comments

@jocave jocave jocave left review comments

@omar-selo omar-selo omar-selo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadzyah @mz2 @omar-selo @jocave